Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial documentation of EpiAware and also sets documentation standard #85

Merged
merged 16 commits into from
Feb 29, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

This PR gives partial documentation to EpiAware, mainly the module.

Also gives a standard for using DocStringExtensions.

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice and from a skim all looks good. Any idea what is going on in CI?

@SamuelBrand1
Copy link
Collaborator Author

This is looking really nice and from a skim all looks good. Any idea what is going on in CI?

The answer is that I was not being careful in adding deps!

EpiAware [b2eeebe4-5992-4301-9193-7ebc9f62c855] does not declare a compat entry for the following deps:
1-element Vector{Base.PkgId}:
DocStringExtensions [ffbed154-4ef7-542d-bbb7-c09d3a79fcae]

Will fix in the morning!

@seabbs
Copy link
Collaborator

seabbs commented Feb 28, 2024

sorry I haven't yet got to this in detail and also for the mess that #89 will bring to this

@seabbs
Copy link
Collaborator

seabbs commented Feb 29, 2024

shall i look at this now? Do you want to ping me to review (top right when ready?)

@SamuelBrand1
Copy link
Collaborator Author

shall i look at this now? Do you want to ping me to review (top right when ready?)

Yeah, there is not alot to review:

  • Use of DocStringExtensions? Is it good/meh/bad.
  • LaTex math... using escape (as per this PR) or some other solution, see here.

Second one I only just noticed.

@SamuelBrand1 SamuelBrand1 requested a review from seabbs February 29, 2024 10:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (8441314) to head (e8b4829).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files           6        6           
  Lines         133      133           
=======================================
  Hits          130      130           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs
Copy link
Collaborator

seabbs commented Feb 29, 2024

@ doc raw

This seems like a cleaner solution than escaping to me for Latex but we could address in its own issue. I definitely like DocStringExtensons (and we should make a template)

@seabbs seabbs enabled auto-merge February 29, 2024 11:04
@SamuelBrand1
Copy link
Collaborator Author

SamuelBrand1 commented Feb 29, 2024

@ doc raw

This seems like a cleaner solution than escaping to me for Latex but we could address in its own issue. I definitely like DocStringExtensons (and we should make a template)

I did a quick try on that, and the problem was that raw kills using the DocStringExtension interpolation... tricky!

E.g. raw string will just write $(TYPEDEF) as a string

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the docs are out of sync with the recent name changes and that AbstractModel isn't present (despite it appearing that this branch is up to date.

EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
EpiAware/Project.toml Outdated Show resolved Hide resolved
@seabbs
Copy link
Collaborator

seabbs commented Feb 29, 2024

I did a quick try on that, and the problem was that raw kills using the DocStringExtension interpolation... tricky!

ah okay. Lets port to another issue for discussion.

@seabbs
Copy link
Collaborator

seabbs commented Feb 29, 2024

s and that AbstractModel isn't present (despite it appearing that this branch is up to date.

It looks like this was missed in #89 but perhaps we are fine with it not being exported?

SamuelBrand1 and others added 7 commits February 29, 2024 11:58
AbstractModel doc mention

Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
@SamuelBrand1 SamuelBrand1 requested a review from seabbs February 29, 2024 12:52
@SamuelBrand1
Copy link
Collaborator Author

I think this is ok now

@seabbs
Copy link
Collaborator

seabbs commented Feb 29, 2024

Aweesome will review now. Could you resolve out the things that are sorted?

EpiAware/src/EpiAware.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues but otherwise good to go.

@seabbs seabbs merged commit f55cd6f into main Feb 29, 2024
5 checks passed
@seabbs seabbs deleted the 81-document branch February 29, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the connect between structs and methods that dispatch on their type
3 participants