-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the basic structure of documenter #93
Conversation
09a8077
to
41eb839
Compare
At a glance this looks good. This is (IMO) an important feature (beautiful docs); I'll do a PR from this branch and try adding some pages using the The typical environment management is to have a |
Is this actually the workflow we want or do we want to write these in some quite of true literate format (i.e quarto or similar?). My instinct was that these should be in the docs file and easier to read than interact with as code (i.e favouring having text not as fancy comment strings) but perhaps that isn't where Julia is? |
Documenter is looking for documenter flavour markdown (I'll call is dfm) to run when you render your documentation (but obviously gfm works too but won't run and then generate plots/output in your documentation) so upstream from that we've got options. Some options
I don't think we need to all do the same workflow to generate the dfm files we want so long as it works? |
Okay for simplicity lets stick with Literate. To get this to be automated though we would need to add a call to Literate.jl in make.jl rather than committing the rendered docs? |
b551042
to
72a2a3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 6 6
Lines 133 133
=======================================
Hits 130 130
Misses 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Really like the doc structure.
For awareness this PR creates the basic
Documenter.jl
structure (inspired heavily by their approach to their own docs) and will also manage deployment. @SamuelBrand1 good to hear if you think this is going in the right direction and if there is anything we should do differently to theDocumenter.jl
approach (as I am just implementing that currently).