Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the basic structure of documenter #93

Merged
merged 20 commits into from
Mar 1, 2024
Merged

Add the basic structure of documenter #93

merged 20 commits into from
Mar 1, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Feb 29, 2024

For awareness this PR creates the basic Documenter.jl structure (inspired heavily by their approach to their own docs) and will also manage deployment. @SamuelBrand1 good to hear if you think this is going in the right direction and if there is anything we should do differently to the Documenter.jl approach (as I am just implementing that currently).

@SamuelBrand1
Copy link
Collaborator

At a glance this looks good.

This is (IMO) an important feature (beautiful docs); I'll do a PR from this branch and try adding some pages using the .jl script -> Documenter flavoured markdown (using Literate) and see what happens when I try and render locally.

The typical environment management is to have a docs environment (iirc), this might just end up being the same as the test env but with Documenter.

@seabbs
Copy link
Collaborator Author

seabbs commented Feb 29, 2024

I'll do a PR from this branch and try adding some pages using the .jl script -> Documenter flavoured markdown (using Literate) and see what happens when I try and render locally.

Is this actually the workflow we want or do we want to write these in some quite of true literate format (i.e quarto or similar?). My instinct was that these should be in the docs file and easier to read than interact with as code (i.e favouring having text not as fancy comment strings) but perhaps that isn't where Julia is?

@SamuelBrand1
Copy link
Collaborator

I'll do a PR from this branch and try adding some pages using the .jl script -> Documenter flavoured markdown (using Literate) and see what happens when I try and render locally.

Is this actually the workflow we want or do we want to write these in some quite of true literate format (i.e quarto or similar?). My instinct was that these should be in the docs file and easier to read than interact with as code (i.e favouring having text not as fancy comment strings) but perhaps that isn't where Julia is?

Documenter is looking for documenter flavour markdown (I'll call is dfm) to run when you render your documentation (but obviously gfm works too but won't run and then generate plots/output in your documentation) so upstream from that we've got options.

Some options

  • My typical workflow: Fancy comment strings in a usual .jl file.
    • Upside: you can just run it from julia from within the doc env to check if it works before rendering to dfm.
    • Downside: You have to be able to read markdown script in your head pretty well.
  • Quarto: .qmd file with nice visual mode for rendering markdown along side code chunks.
    • Upside: Nice format, lots of options to render to.
    • Downside: Have to set up Quarto with jupyter to run code blocks. Outputs to gfm so then you'd need to change it to dfm to get the nice documenter features you want.
  • Others... Haven't tried so much.

I don't think we need to all do the same workflow to generate the dfm files we want so long as it works?

@seabbs
Copy link
Collaborator Author

seabbs commented Feb 29, 2024

Okay for simplicity lets stick with Literate. To get this to be automated though we would need to add a call to Literate.jl in make.jl rather than committing the rendered docs?

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (f55cd6f) to head (f7c5519).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files           6        6           
  Lines         133      133           
=======================================
  Hits          130      130           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs marked this pull request as ready for review February 29, 2024 23:05
@seabbs seabbs requested a review from SamuelBrand1 February 29, 2024 23:05
@seabbs seabbs enabled auto-merge March 1, 2024 10:29
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Really like the doc structure.

@seabbs seabbs merged commit a5a6d27 into main Mar 1, 2024
7 checks passed
@seabbs seabbs deleted the add-documenter branch March 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants