Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 91: Add version 1.10 to testing matrix #96

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Issue 91: Add version 1.10 to testing matrix #96

merged 4 commits into from
Mar 1, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Feb 29, 2024

As the title this PR closes #91 by adding Julia version 1.10 to our testing matrix. It also adds these checks to our required list so that they will need to pass in order for PRs to be merged.

Not that this increases our minimum version from 1.9 to 1.10 and this is required as otherwise we need to update our toml file.

@seabbs seabbs changed the title Issue 91: Add version 1.9 to testing matrix Issue 91: Add version 1.10 to testing matrix Feb 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (a5a6d27) to head (e0428ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files           6        6           
  Lines         133      133           
=======================================
  Hits          130      130           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs enabled auto-merge February 29, 2024 21:08
@SamuelBrand1 SamuelBrand1 self-requested a review March 1, 2024 11:53
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit c4b8e17 into main Mar 1, 2024
10 checks passed
@seabbs seabbs deleted the issue90-1 branch March 1, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Either test EpiAware on Julia 1.9 or update [compat]
3 participants