Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify needed permissions for post-artifact action (at least in private repos) #6

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

dylanhmorris
Copy link
Collaborator

@dylanhmorris dylanhmorris commented Nov 14, 2024

As written, the example for the post-artifact action fails with a 403 when used in a private repo, as it cannot retrieve the artifact. To fix this, we need to specify actions: read and with pull-requests: write under permissions. contents: read is superfluous.

It is not immediately clear to me how easy it would be to produce a reprex in this (public) repo.

Copy link

Thank you for your contribution @dylanhmorris 🚀! Your readme-macos-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-02-12T17:59:47Z. You can re-generate it by re-running the workflow here.)

Copy link

Thank you for your contribution @dylanhmorris 🚀! Your readme-ubuntu-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-02-12T17:59:47Z. You can re-generate it by re-running the workflow here.)

Copy link

Thank you for your contribution @dylanhmorris 🚀! Your readme-windows-latest is ready for download 👉 here 👈!
(The artifact expires on 2025-02-12T17:59:47Z. You can re-generate it by re-running the workflow here.)

Copy link

Thank you for your contribution @dylanhmorris 🚀! Your readme-rocker is ready for download 👉 here 👈!
(The artifact expires on 2025-02-12T17:59:47Z. You can re-generate it by re-running the workflow here.)

@dylanhmorris dylanhmorris changed the title Clarify needed permissions for post-artifact action Clarify needed permissions for post-artifact action (at least in private repos) Nov 14, 2024
@gvegayon
Copy link
Member

Thanks for catching that. I think we could possibly have a private version of a repo that uses this action for testing? We can add it as an issue.

@gvegayon gvegayon merged commit b297c2e into main Nov 16, 2024
4 checks passed
@gvegayon gvegayon deleted the dylanhmorris-clarify-post-artifact-persmissions branch November 16, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants