Build pool on merge to main

[zsusswein]

Currently we're only building pools as part of PRs.

[github-actions]

Thank you for your contribution @zsusswein 🚀! Your pkgdown-site is ready for download 👉 here 👈!
_{(The artifact expires on 2024-12-30T16:03:02Z. You can re-generate it by re-running the workflow here.)}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

[athowes]

Does this mean that tests are run on merge to main as well as in PRs?

And the point of that is that one can verify that main is stable, not only that the PRs that went into main are stable?

[zsusswein]

No, many checks run on merge to main. See their history here. What this PR does is at adds a trigger for the workflow to set up an Azure Batch pool to run as after each push to main. Currently, the build Batch pool deployment only runs on PRs, not after merging so we don't have a "production" Batch pool.

[athowes]

Currently, the build Batch pool deployment only runs on PRs, not after merging so we don't have a "production" Batch pool.

What's the benefit of a "production" Batch pool?

[amondal2]

Will this error out on a push to main event? Since it would technically run after the PR has closed (I think?)

cfa-epinow2-pipeline/.github/workflows/containers-and-az-pool.yaml

Line 41 in 3a11abe

ref: ${{ github.event.pull_request.head.sha }}

[zsusswein]

That's a great point.

I don't see an easy solution here. Perhaps the simplest would be to drop the functionality that parses the commit message. It was a clever idea from George, but it feels optional and building a pool off main is critical.

Thoughts?

[amondal2]

I'm ok with removing as long as it doesn't break the PR pool setup workflow

[gvegayon]

I agree with removing that bit. @amondal2, you seem like a GHA wiz! It'd be great if you could contribute to the cfa-actions project. I would love to replace what we currently have here with the action (https://github.com/CDCgov/cfa-actions/blob/3e3f6ddbd1c4742c9cc830c4fd4e06e131dce587/twostep-container-build/action.yml#L84-L87). We are starting to use this in a few places already, so it would be a nice contribution across projects.