cleanup from attempted run #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsusswein
force-pushed
the
cleanup-from-attempted-run
branch
from
7f0a180 to
37ee7b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
natemcintosh
approved these changes
Oct 3, 2024
|
Failing check is due to #60. It's outside the scope of this PR and will handle separately. |
athowes
reviewed
Oct 8, 2024
athowes
approved these changes
Oct 15, 2024
To the length of the data and throw a warning rather than an error. This change allows us to run on old right-truncation estimates.
for more information, see https://pre-commit.ci
zsusswein
force-pushed
the
cleanup-from-attempted-run
branch
from
382dd0b to
12765cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to do a shadow local run this week alongside the production run. I only ran one state-disease pair.
I had quite a few issues with reading the parameters. Some of those I've noted in #56 and fixed here. Others I've noted in the parameters repo.
Closes #56