Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate detection history into draws vs. logic #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

swo
Copy link
Contributor

@swo swo commented Dec 18, 2024

Aims to resolve #14 -- There are tests for all parts of the logic except the detection resolution

  • This PR separates detection into generation of the relevant quantities, and then the resolution
  • I got around the crazy branching logic by making a list of potential detections (length 0, 1, or 2) and filtering it
  • Add tests for each possible situation:
    • Not eligible for passive nor active
    • Eligible for passive only, and detected
    • Eligible for passive only, but detection after recovery, so no detection
    • 2x tests for active, like the above
    • Both trigger, one of them wins (x2)
    • Both trigger, neither wins

@swo swo force-pushed the swo_simulation_step_tests branch from 891a0cc to d1bd4c5 Compare December 19, 2024 15:03
@swo swo requested a review from afmagee42 December 19, 2024 15:05
@swo swo marked this pull request as ready for review December 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for simulation steps
1 participant