Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate configuration #189

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Automate configuration #189

wants to merge 31 commits into from

Conversation

xop5
Copy link
Collaborator

@xop5 xop5 commented Dec 19, 2024

No description provided.

ryanraaschCDC and others added 30 commits December 3, 2024 21:37
* Update README.md

Bulk of updates

* Update README.md

Added example workflow for helpers section and added some syntax fixes

* Update README.md

Added remaining functions from helpers.py

* Update README.md

Deleting duplicate line

* bump version

* bump version

---------

Co-authored-by: Ryan Raasch <[email protected]>
* ariks fix

* new version

* precommit fixes
* Revert "Remove pre commit"

This reverts commit 60e1c87.

* Styler changes

* renamed main to master
@xop5 xop5 requested a review from ryanraaschCDC December 19, 2024 06:09
t.append(task_id)
return t
tasks.append(task_id)
return tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this add_task() function shouldn't be changed. It's currently setup to return the string task_id name if it's just a single task that gets added and a list if it is multiple. Returning a string is necessary for the new automation functions

Copy link
Contributor

@ryanraaschCDC ryanraaschCDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I found was changing the return of the add_task_to_job function. Other than that it looks good if you've tested out the changes you made to clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants