-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate configuration #189
base: master
Are you sure you want to change the base?
Conversation
* Update README.md Bulk of updates * Update README.md Added example workflow for helpers section and added some syntax fixes * Update README.md Added remaining functions from helpers.py * Update README.md Deleting duplicate line * bump version * bump version --------- Co-authored-by: Ryan Raasch <[email protected]>
* ariks fix * new version * precommit fixes
* Revert "Remove pre commit" This reverts commit 60e1c87. * Styler changes * renamed main to master
t.append(task_id) | ||
return t | ||
tasks.append(task_id) | ||
return tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this add_task() function shouldn't be changed. It's currently setup to return the string task_id name if it's just a single task that gets added and a list if it is multiple. Returning a string is necessary for the new automation functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I found was changing the return of the add_task_to_job function. Other than that it looks good if you've tested out the changes you made to clients
No description provided.