Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runner with arg parsing #114

Merged
merged 2 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,14 @@ seq-macro = "0.3.5"
paste = "1.0.15"
ctor = "0.2.8"
once_cell = "1.20.2"
clap = { version = "4.5.21", features = ["derive"] }
assert_cmd = "2.0.16"

[dev-dependencies]
rand_distr = "0.4.3"
tempfile = "3.3"
ordered-float = "4.3.0"

[[bin]]
name = "runner_test_custom_args"
path = "tests/bin/runner_test_custom_args.rs"
23 changes: 23 additions & 0 deletions examples/runner/main.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
use clap::Args;
use ixa::runner::run_with_custom_args;

#[derive(Args, Debug)]
struct Extra {
#[arg(short, long)]
foo: bool,
}

fn main() {
// Try running this with `cargo run --example runner -- --seed 42`
run_with_custom_args(|context, args, extra: Option<Extra>| {
context.add_plan(1.0, |_| {
println!("Hello, world!");
});
println!("{}", args.random_seed);
if let Some(extra) = extra {
println!("{}", extra.foo);
}
Ok(())
})
.unwrap();
}
30 changes: 17 additions & 13 deletions src/global_properties.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,23 @@ where
for<'de> <T as GlobalProperty>::Value: serde::Deserialize<'de>,
{
let properties = GLOBAL_PROPERTIES.lock().unwrap();
properties.borrow_mut().insert(
name.to_string(),
Arc::new(
|context: &mut Context, name, value| -> Result<(), IxaError> {
let val: T::Value = serde_json::from_value(value)?;
if context.get_global_property_value(T::new()).is_some() {
return Err(IxaError::IxaError(format!("Duplicate property {name}")));
}
context.set_global_property_value(T::new(), val)?;
Ok(())
},
),
);
assert!(properties
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this comment is really that helpful, because it looks like it applies to the whole block

.borrow_mut()
.insert(
name.to_string(),
Arc::new(
|context: &mut Context, name, value| -> Result<(), IxaError> {
let val: T::Value = serde_json::from_value(value)?;
T::validate(&val)?;
if context.get_global_property_value(T::new()).is_some() {
return Err(IxaError::IxaError(format!("Duplicate property {name}")));
}
context.set_global_property_value(T::new(), val)?;
Ok(())
},
),
)
.is_none());
}

#[allow(clippy::missing_panics_doc)]
Expand Down
2 changes: 2 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,5 @@ pub use random::{ContextRandomExt, RngId};

pub mod report;
pub use report::{ConfigReportOptions, ContextReportExt, Report};
pub mod runner;
pub use runner::{run_with_args, run_with_custom_args, BaseArgs};
224 changes: 224 additions & 0 deletions src/runner.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,224 @@
use std::path::{Path, PathBuf};

use crate::context::Context;
use crate::error::IxaError;
use crate::global_properties::ContextGlobalPropertiesExt;
use crate::random::ContextRandomExt;
use crate::report::ContextReportExt;
use clap::{Args, Command, FromArgMatches as _};

/// Default cli arguments for ixa runner
#[derive(Args, Debug)]
pub struct BaseArgs {
/// Random seed
#[arg(short, long, default_value = "0")]
pub random_seed: u64,

/// Optional path for a global properties config file
#[arg(short, long, default_value = "")]
pub config: String,

/// Optional path for report output
#[arg(short, long, default_value = "")]
pub output_dir: String,
}

#[derive(Args)]
pub struct PlaceholderCustom {}

fn create_ixa_cli() -> Command {
let cli = Command::new("ixa");
BaseArgs::augment_args(cli)
}

/// Runs a simulation with custom cli arguments.
///
/// This function allows you to define custom arguments and a setup function
///
/// # Parameters
/// - `setup_fn`: A function that takes a mutable reference to a `Context`, a `BaseArgs` struct,
/// a Option<A> where A is the custom cli arguments struct
///
/// # Errors
/// Returns an error if argument parsing or the setup function fails
#[allow(clippy::missing_errors_doc)]
pub fn run_with_custom_args<A, F>(setup_fn: F) -> Result<(), Box<dyn std::error::Error>>
where
A: Args,
F: Fn(&mut Context, BaseArgs, Option<A>) -> Result<(), IxaError>,
{
let mut cli = create_ixa_cli();
cli = A::augment_args(cli);
let matches = cli.get_matches();

let base_args_matches = BaseArgs::from_arg_matches(&matches)?;
let custom_matches = A::from_arg_matches(&matches)?;
run_with_args_internal(base_args_matches, Some(custom_matches), setup_fn)
}

/// Runs a simulation with default cli arguments
///
/// This function parses command line arguments allows you to define a setup function
///
/// # Parameters
/// - `setup_fn`: A function that takes a mutable reference to a `Context`and `BaseArgs` struct
///
/// # Errors
/// Returns an error if argument parsing or the setup function fails
#[allow(clippy::missing_errors_doc)]
pub fn run_with_args<F>(setup_fn: F) -> Result<(), Box<dyn std::error::Error>>
where
F: Fn(&mut Context, BaseArgs, Option<PlaceholderCustom>) -> Result<(), IxaError>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just do Option<()>. It doesnt' seem like there are any trait bounds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have A implementing Args but i guess for this function it's not actually necessary

{
let cli = create_ixa_cli();
let matches = cli.get_matches();

let base_args_matches = BaseArgs::from_arg_matches(&matches)?;
run_with_args_internal(base_args_matches, None, setup_fn)
}

fn run_with_args_internal<A, F>(
args: BaseArgs,
custom_args: Option<A>,
setup_fn: F,
) -> Result<(), Box<dyn std::error::Error>>
where
F: Fn(&mut Context, BaseArgs, Option<A>) -> Result<(), IxaError>,
{
// Instantiate a context
let mut context = Context::new();

// Optionally set global properties from a file
if !args.config.is_empty() {
println!("Loading global properties from: {}", args.config);
let config_path = Path::new(&args.config);
context.load_global_properties(config_path)?;
}

// Optionally set output dir for reports
if !args.output_dir.is_empty() {
let output_dir = PathBuf::from(&args.output_dir);
let report_config = context.report_options();
report_config.directory(output_dir);
}

context.init_random(args.random_seed);

// Run the provided Fn
setup_fn(&mut context, args, custom_args)?;

// Execute the context
context.execute();
Ok(())
}

#[cfg(test)]
mod tests {
use super::*;
use crate::{define_global_property, define_rng};
use assert_cmd::Command;
use serde::Deserialize;

#[derive(Args, Debug)]
struct CustomArgs {
#[arg(short, long, default_value = "0")]
field: u32,
}

#[test]
fn test_run_with_custom_args() {
let result = run_with_custom_args(|_, _, _: Option<CustomArgs>| Ok(()));
assert!(result.is_ok());
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests don't seem to verify that any of the arguments exist or are correct. It seems like that's really challenging, though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would probably be good to have some integration tests yes, would you be ok if I file that


#[test]
fn test_cli_invocation_with_custom_args() {
// Note this target is defined in the bin section of Cargo.toml
// and the entry point is in tests/bin/runner_test_custom_args
Command::cargo_bin("runner_test_custom_args")
.unwrap()
.args(["--field", "42"])
.assert()
.success()
.stdout("42\n");
}

#[test]
fn test_run_with_args() {
let result = run_with_args(|_, _, _| Ok(()));
assert!(result.is_ok());
}

#[test]
fn test_run_with_random_seed() {
let test_args = BaseArgs {
random_seed: 42,
config: String::new(),
output_dir: String::new(),
};

// Use a comparison context to verify the random seed was set
let mut compare_ctx = Context::new();
compare_ctx.init_random(42);
define_rng!(TestRng);
let result = run_with_args_internal(test_args, None, |ctx, _, _: Option<()>| {
assert_eq!(
ctx.sample_range(TestRng, 0..100),
compare_ctx.sample_range(TestRng, 0..100)
);
Ok(())
});
assert!(result.is_ok());
}

#[derive(Deserialize)]
pub struct RunnerPropertyType {
field_int: u32,
}
define_global_property!(RunnerProperty, RunnerPropertyType);

#[test]
fn test_run_with_config_path() {
let test_args = BaseArgs {
random_seed: 42,
config: "tests/data/global_properties_runner.json".to_string(),
output_dir: String::new(),
};
let result = run_with_args_internal(test_args, None, |ctx, _, _: Option<()>| {
let p3 = ctx.get_global_property_value(RunnerProperty).unwrap();
assert_eq!(p3.field_int, 0);
Ok(())
});
assert!(result.is_ok());
}

#[test]
fn test_run_with_output_dir() {
let test_args = BaseArgs {
random_seed: 42,
config: String::new(),
output_dir: "data".to_string(),
};
let result = run_with_args_internal(test_args, None, |ctx, _, _: Option<()>| {
let output_dir = &ctx.report_options().directory;
assert_eq!(output_dir, &PathBuf::from("data"));
Ok(())
});
assert!(result.is_ok());
}

#[test]
fn test_run_with_custom() {
let test_args = BaseArgs {
random_seed: 42,
config: String::new(),
output_dir: String::new(),
};
let custom = CustomArgs { field: 42 };
let result = run_with_args_internal(test_args, Some(custom), |_, _, c| {
assert_eq!(c.unwrap().field, 42);
Ok(())
});
assert!(result.is_ok());
}
}
18 changes: 18 additions & 0 deletions tests/bin/runner_test_custom_args.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
use clap::Args;
use ixa::runner::run_with_custom_args;

#[derive(Args, Debug)]
struct Extra {
#[arg(short, long)]
field: u32,
}

fn main() {
run_with_custom_args(|_context, _args, extra: Option<Extra>| {
if let Some(extra) = extra {
println!("{}", extra.field);
}
Ok(())
})
.unwrap();
}
5 changes: 5 additions & 0 deletions tests/data/global_properties_runner.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"ixa.RunnerProperty": {
"field_int": 0
}
}
Loading