MVP debugger #123
Merged
MVP debugger #123
+386
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekr-cfa
requested changes
Dec 15, 2024
ekr-cfa
reviewed
Dec 16, 2024
|
|
||
| #[derive(Clone)] | ||
| struct StdoutMock { | ||
| storage: Rc<RefCell<Vec<u8>>>, |
There was a problem hiding this comment.
Why does this have to be an Rc?
There was a problem hiding this comment.
I did this to get around having to pass in a reference that can be stored in the cli struct and modify the vec, but also be able to check it later for tests once you release the cli's reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic cli debugger