generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added random module #18
Merged
+306
−0
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6505831
Added random module
k88hudson-cfa def51f2
Refactor get_rng a bit
k88hudson-cfa a99cedc
Review fixes
k88hudson-cfa 4870f23
Added a test as an example of how to use with a distribution
k88hudson-cfa 1d01a69
Remove Any
k88hudson-cfa 377efb2
Ensure uniqueness of
k88hudson-cfa 23ef220
Switch api to sample / sample_distr
k88hudson-cfa f6a9f3b
namespace type collision guard
k88hudson-cfa 7404c87
add sample_range
k88hudson-cfa 522f24a
Use struct literals and things are better
k88hudson-cfa fc51d73
Goodbye turbofish
k88hudson-cfa d0e2aed
add sample bool
k88hudson-cfa f61ae10
typo
k88hudson-cfa fa7acb4
multiple rng types types name
k88hudson-cfa de14d50
Better test for sample_bool
k88hudson-cfa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
multiple rng types types name
commit fa7acb4ed6745d1234a1ecf233e6c14fdaf75f81
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -206,7 +206,7 @@ mod test { | |
} | ||
|
||
#[test] | ||
fn multiple_references_with_drop() { | ||
fn multiple_rng_types() { | ||
let mut context = Context::new(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test doesn't seem to do what it says. |
||
context.init_random(42); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is conceptually like the eosim code, but we also talked about a version where you didn't get the RNG but just told it what distribution to draw from. @jasonasher did you ever prototype that.