fix: update fhir-converter to dotnet 8 #3080
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3080 +/- ##
==========================================
- Coverage 86.54% 84.63% -1.91%
==========================================
Files 215 160 -55
Lines 13432 9341 -4091
Branches 668 666 -2
==========================================
- Hits 11625 7906 -3719
+ Misses 1798 1426 -372
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. |
mcmcgrath13
requested review from
akasper,
angelathe,
austin-hall-skylight,
BobanL,
gordonfarrell,
JNygaard-Skylight,
lina-roth and
robertmitchellv
as code owners
mcmcgrath13
commented
Dec 18, 2024
|
|
||
| # Download FHIR-Converter | ||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch v7.0-skylight-18 --single-branch /build/FHIR-Converter | ||
| RUN git clone https://github.com/skylight-hq/FHIR-Converter.git --branch mcm/dotnet-8 --single-branch /build/FHIR-Converter |
There was a problem hiding this comment.
todo: update to release version before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Pull in latest updates from upstream Microsoft FHIR Converter, including updgrade to dotnet 8, which requires updating the dockerfile for the service. Corresponds to skylight-hq/FHIR-Converter#25
Related Issue
Fixes #3060