Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable additional eslint rules #3089

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 26, 2024

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

Fixes #

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.36%. Comparing base (a9d82ef) to head (8e2a37f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ntainers/ecr-viewer/src/app/components/Filters.tsx 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3089      +/-   ##
==========================================
+ Coverage   86.75%   88.36%   +1.61%     
==========================================
  Files         217       81     -136     
  Lines       13527     4100    -9427     
  Branches      690      694       +4     
==========================================
- Hits        11735     3623    -8112     
+ Misses       1770      455    -1315     
  Partials       22       22              
Flag Coverage Δ
ecr-viewer 89.79% <97.50%> (+0.01%) ⬆️
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iners/ecr-viewer/src/app/components/BaseFilter.tsx 88.23% <100.00%> (ø)
...viewer/src/app/components/EcrPaginationWrapper.tsx 88.88% <ø> (ø)
...s/ecr-viewer/src/app/components/EcrTableClient.tsx 91.86% <ø> (ø)
...iners/ecr-viewer/src/app/components/Pagination.tsx 100.00% <100.00%> (ø)
...iners/ecr-viewer/src/app/components/SortButton.tsx 17.64% <ø> (ø)
...iewer/src/app/view-data/components/DataDisplay.tsx 97.18% <100.00%> (-0.04%) ⬇️
.../src/app/view-data/components/LoadingComponent.tsx 100.00% <100.00%> (ø)
containers/ecr-viewer/src/app/view-data/page.tsx 89.58% <ø> (ø)
.../ecr-viewer/src/app/view-data/retrieval-failed.tsx 100.00% <ø> (ø)
...ntainers/ecr-viewer/src/app/components/Filters.tsx 94.59% <95.23%> (+1.26%) ⬆️

... and 141 files with indirect coverage changes

@BobanL BobanL force-pushed the boban/refactor-eslint branch from 817d84f to 7cc560d Compare December 27, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant