-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 216: end-to-end CI #247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
========================================
+ Coverage 7.96% 8.17% +0.20%
========================================
Files 20 21 +1
Lines 1343 1346 +3
========================================
+ Hits 107 110 +3
Misses 1236 1236
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Blocked by an error
Which is unexpected because the data is generated in sequence. I'll parse this tomorrow. |
That error was due to differing names of disease across different data sets. Onto creating eval data. |
Through the eval data and into
This was due to the pipeline wanting to be run from root dir |
pipeline now runs locally |
These will trigger CI fails to avoid false CI passes
This seems to be running but noting that without the |
I've tried more "minimalistic" settings e.g. fewer look back points, but occasionally you get fails due to bad sampling propagating something unexpected along the pipeline. At this moment I'm using 90 days data for inference and drawing a single 500/500 chain. Exploring the fastest option that 1) doesn't fail stochastically, 2) still covers the pipeline sufficiently to avoid false CI passes would be a good issue. |
I think this is now erroring because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamuelBrand1 After I added the quarto action, all checks are passing. On Teams you alluded to a potential other issue, so holding off on approval for now.
Nice! Thanks @damonbayer . The other issue was using deps that need to be installed with This should be good to review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SamuelBrand1. This is a huge improvement for the repo!
This PR closes #216.
Steps:
hewr
function to generate count data from times series of exponential ratespipeline
function to use above to create dummy data with this schema https://gist.github.com/damonbayer/63bfeab36514806896cd06dc0235d1ea @damonbayerThis PR adds a CI which installs relevant deps, then runs a test script which first creates fake test data from an exponentially mean-varying Poisson process and then runs the forecasting pipeline script. The target pathogen is covid-19 and the target state is "CA" (chosen arbitrarily).