Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify generate_epiweekly #259

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

dylanhmorris
Copy link
Contributor

  • use id_cols argument to forecasttools::daily_to_epiweekly, which avoids need for a group_modify() call

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.08%. Comparing base (f275238) to head (b49d0b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   17.08%   17.08%           
=======================================
  Files          21       21           
  Lines        1346     1346           
=======================================
  Hits          230      230           
  Misses       1116     1116           
Flag Coverage Δ
hewr 48.79% <ø> (ø)
pipelines 0.00% <ø> (ø)
pyrenew_hew 1.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer merged commit dd075ca into main Dec 19, 2024
15 checks passed
@damonbayer damonbayer deleted the dhm-simplify-generate-epiweekly branch December 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants