-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure 2 rough draft components #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks largely good. A couple minor comments.
…easier to prototype formatting outside of R
Converting back to a draft because I realized I forgot to make the second half of what was planned for Fig 2 (the forecast comparison plots by location and horizon, with CRPS underlaid) |
Ok @dylanhmorris this is ready for review. Let me know if you'd prefer I just put all the figures in one PR, I figured breaking it up would be slightly easier. All the drafts are in the link to the cdcent repo issue. In order to make the completed planned figure 2, we'd have to repeat a bunch of generations of the subpanels for the different locations, I left that out of the targets pipeline for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor but key questions @kaitejohnson
Co-authored-by: Dylan H. Morris <[email protected]>
Co-authored-by: Dylan H. Morris <[email protected]>
@dylanhmorris Let me know what you think of this. I added the additional I still have an open question about what |
Update, going to switch to creating |
Ok this is ready for re-review, let me know if you want me to make them into one function though @dylanhmorris |
Co-authored-by: Dylan H. Morris <[email protected]>
Co-authored-by: Dylan H. Morris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One documentation wording suggestion.
Co-authored-by: Dylan H. Morris <[email protected]>
The point of this figure is to show an example comparing the forecasts of the wastewater model and the hospital admissions model for a few states (can decide on the states later), paired with the fits/forecasts to a subset of the wastewater data for that state.
This PR creates (separately) the ggplot components for the example hospital admissions forecasts colored by model type + the fits and forecasts to the wastewater concentrations for those example states.
See private repo for produced figures.
Note: The goal here is just to have the structure in place to generate the figures. All formatting decisions will be made in a second round of revisions. Am still using the
{targets}
pipeline for creating all of these, which enables caching and allows us to pass the post-processed objects/ mix analysis in with figure production when needed.