Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a warning message and a new file to write out missing files #103

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

kaitejohnson
Copy link
Collaborator

This PR adds the functionality to generate warning messages when our "roll-your-own" version of tar_combine() (called combine_outputs() tries to load in a file and fails. This is helpful because some of these seem to have been killed jobs on Azure that we would only know by spot checking manually (which is not ideal) and we would just need to rerun them.

I added functionality to write it into a file, we could make this optional. My thinking here is most of this analysis is really for our own evaluation analysis rather than very general tooling, so its maybe okay to do something like this, but happy to change if we want to push towards maximizing user generality.

wweval/R/combine_outputs.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a unit test for this function to confirm it does indeed create the file as needed, but that can be a separate PR. Make an issue?

@kaitejohnson kaitejohnson merged commit 027a5f8 into prod Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants