Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scoringutils::transform_forecasts() instead of manual transform #122

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

kaitejohnson
Copy link
Collaborator

This PR closes #113. I had been manually transforming data and predictions and then using score. This uses built in functionality in scoringutils. Setting the logshift to 1 not 1e-8.

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dylanhmorris dylanhmorris merged commit 826db2b into prod Jul 30, 2024
5 checks passed
@dylanhmorris dylanhmorris deleted the 113-logtransform-w-scoringutils branch July 30, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use scoringutils::transform_forecasts() instead of writing own
3 participants