Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 23: Suppress some Stan output #24

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jun 4, 2024

Closes #23.

I've limited the amount of Stan output that is shown in the vignette. I've also fixed the display of one header at the end.

@seabbs seabbs requested a review from kaitejohnson June 4, 2024 15:38
@kaitejohnson
Copy link
Collaborator

Thanks for doing this @athowes! I will approve as soon as we get the test data fixed and merge over from the developed on codebase (that was our decided on temporary solution for the change in the stan rng, which is why this is failing the CI test)

@athowes
Copy link
Collaborator Author

athowes commented Jun 4, 2024

There are some other stylistic / formatting things I'd likely change about the vignette. Let me know if worthwhile to go through and suggest those changes / now is a reasonable time to do that. (I'm interested to get up to speed with the model and doing this is one way to start with that.)

@kaitejohnson
Copy link
Collaborator

@athowes That would be awesome, please go ahead!

Copy link
Collaborator

@kaitejohnson kaitejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@athowes
Copy link
Collaborator Author

athowes commented Jun 7, 2024

(This isn't merged by the way?)

@dylanhmorris dylanhmorris merged commit 5545075 into CDCgov:prod Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large amount of Stan output in vignette
3 participants