2024-08-07 update : adding matrix normalization func. and using AR1 in spatial func.

[cbernalz]

This PR is regarding two issues : #52 (comment) and #50 (comment) .

[dylanhmorris]

A few minor things. Looks generally very good.

[kaitejohnson]

Just one suggestion for an additional test of the normalization matrix function.

[kaitejohnson]

This is looking great! I just realized that we should also add the ar1 process call to construct_spatial_rt_process.stan.

ww-inference-model/inst/stan/functions/construct_spatial_rt.stan

Line 29 in 5e2403d

spatial_deviation_t_i = (spatial_deviation_ar_coeff*spatial_deviation_t_i)

I think for that one, you will have to for z pass in the iid normal deviation (not with the separate sd). Think you can write as is and pass in 1 for the sd.

[dylanhmorris]

Two coments:

1. Suggest changing init_bool to init_stat throughout and clarifying the documentation.
2. When processes that take in standard normal vectors and transform them, we should use the built-in rngs to generate the standard normals, rather than custom ones.

[kaitejohnson]

This is looking great! I just realized that we should also add the ar1 process call to construct_spatial_rt_process.stan.

ww-inference-model/inst/stan/functions/construct_spatial_rt.stan

Line 29 in 5e2403d

spatial_deviation_t_i = (spatial_deviation_ar_coeff*spatial_deviation_t_i)

I think for that one, you will have to for z pass in the iid normal deviation (not with the separate sd). Think you can write as is and pass in 1 for the sd.

Update: ignore this comment. I misunderstood how we were doing this here.

[dylanhmorris]

A few typos but very close @cbernalz

[dylanhmorris]

Correcting my own mistake, apologies

[dylanhmorris]

LGTM, thanks @cbernalz!

change request withdrawn, see #53 (comment)