Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility landing and basic edit pages "forms" for #543 #813

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sfisher
Copy link
Contributor

@sfisher sfisher commented Dec 14, 2024

Fix labels to have a "for" for non-form elements (though it's not a usual way to write html). Fixing other things broken on landing and basic edit page.

See #543 for ticket and comments.

…ments (though it's not a usual way to write html). Fixing other things broken on landing and basic edit page.
@sfisher sfisher requested a review from jsjiang December 14, 2024 00:03
@sfisher sfisher changed the title Making changes for #543 Accessibility landing and basic edit pages forms for #543 Dec 16, 2024
@sfisher sfisher changed the title Accessibility landing and basic edit pages forms for #543 Accessibility landing and basic edit pages "forms" for #543 Dec 16, 2024
Copy link
Contributor

@jsjiang jsjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. We can put it on dev or stage for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants