-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop drakvuf to v0.8-backports version #839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrok1
force-pushed
the
drakvuf-downgrade
branch
from
January 19, 2024 14:12
88c7987
to
a05de70
Compare
msm-cert
reviewed
Jan 19, 2024
Co-authored-by: msm-cert <[email protected]>
msm-cert
reviewed
Jan 19, 2024
Co-authored-by: msm-cert <[email protected]>
msm-cert
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drakvuf downgrade to last stable version that actually works on CERT.pl production setup.
After tests, drakvuf-sandbox has not been proven stable enough to work with Drakvuf v1.0, so we need to make a step back and then try once again. Changes before the downgrade are tracked on
drakvuf-v1.x
branch, so things applicable only to v1.0+ version can be still developed there.If you read this to roll it back to v1.0:
.github/workflows/build.yml
changes should be OK for both versions, only SNAPSHOT_VERSION must be changed