Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling of rulenames badges wraps properly #419

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mickol34
Copy link
Collaborator

@mickol34 mickol34 commented Oct 9, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
Currently badges in query result page go out of page when given too long names, as per https://user-images.githubusercontent.com/20182642/82444130-6a327c00-9aab-11ea-8693-63cf5dcb0cce.gif #196

What is the new behaviour?

Now badges wrap properly to new line with additional text linebreaks.

Test plan

Try to search for a query with multiple rule names, some of them very long and try to match many files to see if multiple result search also works properly. Try resizing the window, zooming in and out and try to find unexpected/unwished for behavior.

Closing issues

fixes #196

@mickol34
Copy link
Collaborator Author

mickol34 commented Oct 9, 2024

Current behavior with singular search shown below.
Screencast from 2024-10-09 10-06-44.webm

@mickol34 mickol34 marked this pull request as ready for review October 9, 2024 08:18
@mickol34 mickol34 requested a review from msm-cert October 9, 2024 08:18
Copy link
Member

@msm-cert msm-cert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think!

I hope the filename won't get cut too often instead 🤔

@msm-cert msm-cert merged commit 10351e6 into master Oct 11, 2024
10 checks passed
@msm-cert msm-cert deleted the fix/badges-wrapping-properly-196 branch October 11, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ellipsis hides matched-rules badges
2 participants