Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to ignore migration errors #430

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

msm-cert
Copy link
Member

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
On migration error process dies because of unhandled exception and becomes a zombie

What is the new behaviour?
On migration error a clear error is logged, and process tries to keep going.

@msm-cert msm-cert requested a review from MichalJura October 22, 2024 21:47
@msm-cert msm-cert force-pushed the fix/ignore-migration-crashes branch from 812765b to f909e37 Compare October 22, 2024 21:52
@msm-cert msm-cert force-pushed the fix/ignore-migration-crashes branch from f909e37 to bf8942e Compare October 22, 2024 21:52
src/app.py Show resolved Hide resolved
@msm-cert msm-cert added this to the v1.5.0 milestone Oct 23, 2024
@msm-cert msm-cert merged commit 2713b7f into master Oct 23, 2024
10 checks passed
@msm-cert msm-cert deleted the fix/ignore-migration-crashes branch October 23, 2024 12:01
mickol34 pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants