Make fields nullable again #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm-cert
force-pushed
the
fix/restore-field-nullability
branch
3 times, most recently
from
18cca74 to
e1e5704
Compare
msm-cert
force-pushed
the
fix/restore-field-nullability
branch
from
e1e5704 to
79a4977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #412 the database status is not equivalent to schema in the code, and migrations want to change job_id fields to nullable. In that PR they were changed from a simple Field() to a Field(sa_column=...) which triggered this change.
This means that now trying to create a new migration will add two unrelated changes (job_id for jobagent and match).
This PR bumps sqlmodel and makes them non-nullable again.