Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration-guide.rst - update to AboutView from About #882

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

vividDuck
Copy link
Contributor

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
The template code in the doc does not build with npm. The About component is not imported as it does not exist:

import About from "@mwdb-web/components/About";

The doc also hid some of the code-blocks due to a missing newline after the placeholder.

What is the new behaviour?
Updating the template code to import the AboutView

import { AboutView } from "@mwdb-web/components/Views/AboutView";

Test plan

Closing issues

closes #issuenumber

Update web plugin import of the About component
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@psrok1 psrok1 merged commit 52a8353 into CERT-Polska:master Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants