OIDC: Refactor to expose OIDC client object #971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Description of changes
I don't really like the documentation of authlib and the current design of mixins. That's why I think it's a bit unsafe to mix with OAuth2Session and it's much better to make a wrapper that will be exposed via
OpenIDProvider.get_oidc_client
method.Additional thing is that in future PRs we need to make a series of calls to the provider using fetched access token, we can't do that with current
_get_client
method that createsOpenIDSession
object internally and disposes it right after the call.The third thing is that we need to strip
OpenIDClient
methods from unused code paths, copied fromOpenIDMixin
.Test plan
Right now it needs to be tested manually using
docker-compose-oidc-dev