Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: Reference group by FK, set workspace attribute to False #974

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Aug 20, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

  • Group created for OIDC provider is referenced by name but should be referenced by id
  • Workspace attribute is set to True which cannot be changed and causes "automatic" sharing of uploads between users coming from the same provider

What is the new behaviour?

  • OIDC group is referenced by foreign key
  • Set workspace attribute to False for all OIDC groups

Test plan

Tested manually: both migration and fresh creation of the OIDC provider and members.

Closing issues

closes #973

@psrok1 psrok1 merged commit b15ba09 into master Aug 20, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/oidc-group-foreign-key branch August 20, 2024 14:34
@psrok1 psrok1 mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC group is always a "workgroup" - it cannot be changed and is not always desired
1 participant