-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RunPython #468
RunPython #468
Conversation
I was already okay with removing native Python support but this also looks nice :). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 44.30% 44.30%
=======================================
Files 169 169
Lines 7896 7896
=======================================
Hits 3498 3498
Misses 4398 4398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Very exciting, thanks @llaniewski ! Do you want me to test it using the two-phase fracture setup I was working on? |
@shkodm I think I would like you to test on the fracture setup, and maybe add to the multiphase tools repo as a demo for using it ;) |
@shkodm That would be great. Hope this will simplify your setup a bit. edit: Of course, after you come back to the office. @TravisMitchell @shkodm Some notes:
|
@llaniewski I tested, and it seems to work for my purposes now (plotting phase field on the aperture plot). We can probably merge this one directly now and then create follow up PRs if I find some issues. Regarding notes:
|
This PR extends the RunR capabilities with Python execution through the
reticulate
. You can now execute Python code with<RunPython/>
element, whereSolver
is exposed in the same way as in R.Example
FYI: @TravisMitchell @shkodm @mdzik
I think with this present in the code we can get rid of the native Python support.