Sonata Pinmux driver #360
Open
Sonata Pinmux driver #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnovandermaas
approved these changes
Nov 27, 2024
|
I think in the case of the Pinmux it's best to make sure sink names match the canonical name used documentation, RTL and schematic. The sinks are enum classes, so breaking the code style shouldn't cause much confusion here. |
nwf
requested changes
Dec 2, 2024
There was a problem hiding this comment.
It looks like platform-pinmux.hh is generated from sonata-system's platform-pinmux.hh.tpl via its top_gen. It'd be good to...
- have a comment to that effect in the file
- update the
.hh.tplin light of the changes made here (NOLINT, names of some function arguments and locals, &c).
FWIW, I ran git diff --word-diff having clobbered sonata-system v0.3-403-g658a741's sw/cheri/common/platform-pinmux.hh with the one from this PR; that might be the easiest way to find the requisite changes to the template?
I have not attempted to validate that top_gen is consistent between the RTL and C++ it generates, much preferring to merely assume so. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A driver for Sonata v1.0's Pinmux