Simplified the sonata PWM driver #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are now 6 general purpose PWM outputs and one dedicated to the LCD's backlight. Instead of implementing the indexing logic and checks in the driver. The driver is changed to only over map to a single PWM output. We simply alias an array of these for the general purpose PWM memory region. The dutyCycle <= period assertion was removed, because dutyCycle > period is the only way to acheive a constant high, 100% duty cycle output from the Sonata system's PWM block.
|
|
||
| /// A convenience structure that can map onto multiple PWM outputs. | ||
| template<size_t NumberOfPwms = 6> | ||
| struct Array |
There was a problem hiding this comment.
Is there a reason that this isn't a std::array? It looks like it's equivalent to a subset of std:array.
There was a problem hiding this comment.
Is it for the compile-time bounds checking?
There was a problem hiding this comment.
I originally used std::array but found a lot of std::array's methods don't work with utils::NoCopyNoMove elements.
marnovandermaas
approved these changes
Nov 28, 2024
davidchisnall
approved these changes
Nov 28, 2024
| @@ -1,37 +1,21 @@ | |||
| #pragma once | |||
| #include <array> | |||
There was a problem hiding this comment.
I think this is stale now?
| */ | ||
| using General = Array<6>; | ||
| /// There is one dedicated PWM for the LCD backlight. | ||
| using Lcd = Output; |
There was a problem hiding this comment.
Maybe call this LcdBacklight? It's a bit confusing to have a thing called Lcd that isn't the LCD interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.