[DNM, WIP] 2024/01 catch up with dependencies #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf-msr
force-pushed
the
202401-catch-up
branch
from
6572bc0
to
429055a
Compare
nwf-msr
force-pushed
the
202401-catch-up
branch
from
429055a
to
d59cf42
Compare
Adapt Alex's 182dc52ef468884f31c0e002118a8c75df0a69fb
Adapts Alex's 3e6a55f69ee74ba5dcbd63506f992151870c24a6
This is a strict subset of the sail-riscv model's riscv_step_rvfi.sail to omit fregs absent in CHERIoT.
nwf-msr
force-pushed
the
202401-catch-up
branch
from
d59cf42
to
0c38f6b
Compare
|
Looks like you've committed a subrepo pointer with local patches applied so it points at a commit that doesn't exist upstream. As David says we should find a better way to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes catch us up with the (TBA) sail 0.17.2 and riscv/sail-riscv#371 once that lands. Once it does, this series can also bump the submodule commit.