Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candperm: brown paper bag fix for #83 #90

Merged
merged 1 commit into from
Dec 2, 2024
Merged

candperm: brown paper bag fix for #83 #90

merged 1 commit into from
Dec 2, 2024

Conversation

nwf
Copy link
Member

@nwf nwf commented Dec 2, 2024

Sigh, sorry. This was originally "~(mask | perm_global) == zeros()" and had one too many inversions applied.

Sigh, sorry.  This was originally "~(mask | perm_global) == zeros()" and
had one too many inversions applied.
Copy link
Contributor

@kliuMsft kliuMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@rmn30 rmn30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed that in the review!

@rmn30 rmn30 merged commit 2015e1c into main Dec 2, 2024
2 checks passed
@rmn30 rmn30 deleted the 202412-fix-83 branch December 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants