remove silent failure on cancel (#13)

CKS-Systems · Aug 26, 2024 · b735660 · b735660
1 parent f3fb5a3
commit b735660
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/programs/manifest/src/state/market.rs b/programs/manifest/src/state/market.rs
@@ -861,10 +861,8 @@ impl<Fixed: DerefOrBorrowMut<MarketFixed>, Dynamic: DerefOrBorrowMut<[u8]>>
             }
         }
 
-        // TODO: Remove the silent failures
-        // Silently fails because order could have matched before our cancel got
-        // there and that is correct behavior in that case.
-        Ok(())
+        // Do not fail silently.
+        Err(ManifestError::InvalidCancel.into())
     }
 
     pub fn cancel_order_by_index(

diff --git a/programs/manifest/tests/cases/cancel_order.rs b/programs/manifest/tests/cases/cancel_order.rs
@@ -95,8 +95,8 @@ async fn cancel_order_sequence_number_not_exist_test() -> anyhow::Result<()> {
         .place_order(Side::Ask, 1, 1, 0, u32::MAX, OrderType::Limit)
         .await?;
 
-    // Sequence number does not exist, but it fails open.
-    test_fixture.cancel_order(1234).await?;
+    // Sequence number does not exist. It fails closed.
+    assert!(test_fixture.cancel_order(1234).await.is_err());
 
     Ok(())
 }