Comment explaining price in fill log result

client/ts/src/fillFeed.ts

@@ -213,7 +213,7 @@ function toFillLogResult(
     taker: fillLog.taker.toBase58(),
     baseAtoms: fillLog.baseAtoms.inner.toString(),
     quoteAtoms: fillLog.quoteAtoms.inner.toString(),
-    price: convertU128(fillLog.price.inner),
+    priceAtoms: convertU128(fillLog.price.inner),
     takerIsBuy: fillLog.takerIsBuy,
     isMakerGlobal: fillLog.isMakerGlobal,
     makerSequenceNumber: fillLog.makerSequenceNumber.toString(),

client/ts/src/types.ts

@@ -12,8 +12,8 @@ export type FillLogResult = {
   baseAtoms: string;
   /** Number of quote atoms traded. */
   quoteAtoms: string;
-  /** Price as float. Quote atoms per base atom. */
-  price: number;
+  /** Price as float. Quote atoms per base atom. Client is responsible for translating to tokens. */
+  priceAtoms: number;
   /** Boolean to indicate which side the trade was. */
   takerIsBuy: boolean;
   /** Boolean to indicate whether the maker side is global. */

debug-ui/app/components/Fills.tsx

@@ -53,6 +53,7 @@ const Fills = ({ marketAddress }: { marketAddress: string }): ReactElement => {
           Number(fill.baseAtoms) /
           10 ** Number(marketRef.current?.baseDecimals() || 0);
 
+        // Price is the actual price which factors in rounding, not the limit price.
         const priceTokens = Number((quoteTokens / baseTokens).toFixed(4));
         const fillUi: FillResultUi = {
           market: fill.market,

debug-ui/scripts/stats-server.ts

@@ -74,7 +74,7 @@ export class ManifestStatsServer {
   private baseVolumeAtomsCheckpoints: Map<string, number[]> = new Map();
   private quoteVolumeAtomsCheckpoints: Map<string, number[]> = new Map();
 
-  // Last price by market
+  // Last price by market. Price is in atoms per atom.
   private lastPriceByMarket: Map<string, number> = new Map();
 
   // Market objects used for mints and decimals.
@@ -111,7 +111,7 @@ export class ManifestStatsServer {
 
     this.ws.onmessage = async (message) => {
       const fill: FillLogResult = JSON.parse(message.data.toString());
-      const { market, baseAtoms, quoteAtoms, price, slot } = fill;
+      const { market, baseAtoms, quoteAtoms, priceAtoms, slot } = fill;
 
       // Do not accept old spurious messages.
       if (this.lastFillSlot > slot) {
@@ -144,13 +144,13 @@ export class ManifestStatsServer {
       }
       lastPrice.set(
         { market },
-        price *
+        priceAtoms *
           10 **
             (this.markets.get(market)!.baseDecimals() -
               this.markets.get(market)!.quoteDecimals()),
       );
 
-      this.lastPriceByMarket.set(market, price);
+      this.lastPriceByMarket.set(market, priceAtoms);
       this.baseVolumeAtomsSinceLastCheckpoint.set(
         market,
         this.baseVolumeAtomsSinceLastCheckpoint.get(market)! +

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cks-systems/manifest-sdk",
-  "version": "0.1.68",
+  "version": "0.1.69",
   "files": [
     "dist/",
     "README.md",