Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certora's formal verification effort for Manifest #293

Closed
wants to merge 1 commit into from

Conversation

brittcyr
Copy link
Contributor

@brittcyr brittcyr commented Nov 20, 2024

DO NOT SUBMIT
creating pull request to make it easier to see what needs to be done in the merge

* Certora's formal verification effort for Manifest
- Verification rules are in `programs/manifest/src/certora/spec`
- Mock for red-black tree in `cvt_db_mock.rs`
- Mock for QuoteAtomsPerBaseAtoms in `quantities_certora.rs`
- Uses conditional compilation with feature `certora` to plug in the mocks
- See the accompanying audit report for additional details

* specs: add rules for matching mechanism

---------

Co-authored-by: caballa <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 65.56291% with 364 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
programs/manifest/src/state/market_helpers.rs 16.80% 292 Missing ⚠️
programs/manifest/src/state/market.rs 80.61% 38 Missing ⚠️
...rograms/manifest/src/program/processor/withdraw.rs 71.79% 33 Missing ⚠️
...ams/manifest/src/program/processor/batch_update.rs 97.91% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants