-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constrained vertex fit for R(K) #89
base: master
Are you sure you want to change the base?
Conversation
Dear all, I have modularized the constrained vertex fit. Best, |
BParkingNano/test/run_nano_cfg.py
Outdated
'nanoAOD_KstarMuMu_step', | ||
'nanoAOD_KstarEE_step', | ||
#'nanoAOD_KstarMuMu_step', | ||
#'nanoAOD_KstarEE_step', | ||
) | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ottolau,
can you remove the changes to the run_nano_cfg.py ?
This is not part of your PR, will confuse the history and introduce in the master branch unwanted changes in general
@ottolau by the way, thanks! |
Hi Arabella, Thanks! I just changed back the run_nano_cfg.py file. For the size and timing, since the additional vertex fit is modularized, I just ran this PR and check the timing report of the new module. I ran both Kee and Kmumu, while Kmumu is negligible. Best, |
thanks Otto, my question was rather if you run the same version of run_nano_cfg.py on the HEAD branch and PR branch, |
Hi all, Here is the validation. Best, |
Dear all,
This is a PR of putting constrained vertex fit to the common framework. I haven't checked the error matrix issue yet by now.
Best regards,
Otto