-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match electrons to photon conversion tracks #92
Conversation
Needs a little more work, but feel free to start taking a look ... |
Ok, so this now ready for review @gkaratha @nancymarinelli. Most of the code is here and here and it is used here. This configurable (current default = True) controls whether we add several variables to the electron table or not. Otherwise, we just store simple flags that indicate if a match between an electron and a conversion was found, with various working points defined for the latter ("open", "loose", "tight"). These are based on code and presentations from Nancy and must be checked! Also please check the logic, which is based on Nancy's selection code here and matching code here. Thanks! |
all ok @gkaratha @nancymarinelli ? |
seems ok as far as I can tell
…On 09/11/20 23:42, bainbrid wrote:
all ok @gkaratha @nancymarinelli ?
--
________________________________________
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
Hi @bainbrid , |
Shall I merge? Do you want to test it first? (ie. run with it?) I have tested on MC and data, but only in a limited fashion using the provided example cfg file. |
BTW, the default config will add to the tree:
|
Potential issues to address in a new PR:
|
This PR is based on code in Nancy's ConversionSelector RR, #84.
Please check carefully on the logic and comment if necessary!
@gkaratha @amartelli @nancymarinelli @ottolau @crovelli