Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match electrons to photon conversion tracks #92

Merged
merged 9 commits into from
Nov 12, 2020
Merged

Match electrons to photon conversion tracks #92

merged 9 commits into from
Nov 12, 2020

Conversation

bainbrid
Copy link
Contributor

@bainbrid bainbrid commented Nov 3, 2020

This PR is based on code in Nancy's ConversionSelector RR, #84.

  • the main developments are in a new ConversionInfo class, which is used in the ElectronMerger module,
  • pat::Electrons are matched to reco::Conversions from the gsfTracksOpenConversions collection,
  • flags are stored in the electronBPark table to indicate if each electron is matched to a conversion, which may satisfy various WPs (open, loose, tight),
  • several "raw" variables are also stored in the electronBPark table if a boolean configurable is set, which may be used to apply additional/tuned selections to the conversion candidates.

Please check carefully on the logic and comment if necessary!

@gkaratha @amartelli @nancymarinelli @ottolau @crovelli

@bainbrid
Copy link
Contributor Author

bainbrid commented Nov 3, 2020

Needs a little more work, but feel free to start taking a look ...

@bainbrid
Copy link
Contributor Author

bainbrid commented Nov 4, 2020

Ok, so this now ready for review @gkaratha @nancymarinelli.

Most of the code is here and here and it is used here.

This configurable (current default = True) controls whether we add several variables to the electron table or not. Otherwise, we just store simple flags that indicate if a match between an electron and a conversion was found, with various working points defined for the latter ("open", "loose", "tight"). These are based on code and presentations from Nancy and must be checked! Also please check the logic, which is based on Nancy's selection code here and matching code here.

Thanks!

@bainbrid bainbrid changed the title WIP: match electrons to photon conversion tracks Match electrons to photon conversion tracks Nov 4, 2020
@bainbrid
Copy link
Contributor Author

bainbrid commented Nov 9, 2020

all ok @gkaratha @nancymarinelli ?

@nancymarinelli
Copy link

nancymarinelli commented Nov 11, 2020 via email

@gkaratha
Copy link
Contributor

Hi @bainbrid ,
I think is fine as well
best,
george

@bainbrid
Copy link
Contributor Author

Shall I merge? Do you want to test it first? (ie. run with it?) I have tested on MC and data, but only in a limited fashion using the provided example cfg file.

@bainbrid
Copy link
Contributor Author

BTW, the default config will add to the tree:

  • various flags that indicate if matched to a conversion
  • as well as the extra variables shown here, which can be switched off using this configurable boolean.

@bainbrid bainbrid merged commit 289fe0f into master Nov 12, 2020
@bainbrid
Copy link
Contributor Author

Potential issues to address in a new PR:

  • Check mass variable to cut on? Remove mass cut from Tight selection?
  • Add deltaCotgTheta cut?
  • Add radius cut? Relax radius cut to 0. < R < 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants