[AB2D-6149] increase ab2d-filters test coverage
#388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Jun 7, 2024
| ExplanationOfBenefit eobSNF = (ExplanationOfBenefit) eobS; | ||
| List<org.hl7.fhir.dstu3.model.Identifier> ids = eobSNF.getIdentifier(); | ||
| assertNotNull(ids); | ||
| assertEquals(ids.size(), 2); |
There was a problem hiding this comment.
The syntax is assertEquals(expected, actual)
coilysiren
commented
Jun 7, 2024
| @@ -30,7 +30,7 @@ public class EOBLoadUtilitiesTest { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testType() { | |||
There was a problem hiding this comment.
Tests don't need to be marked public
coilysiren
changed the title
coilysiren
changed the title
ab2d-filters test coverage
coilysiren
commented
Jun 10, 2024
Comment on lines
+34
to
+49
| // Our mock FhirVersion class is used to test the switch case statement inside of EOBLoadUtilities.getEOBFromReader. | ||
| // We need to extend from a FhirVersionEnum that is actually on our classpath, so we extend from the R4 version. | ||
| // We then override the getVersion method to return a version that is not supported by the switch case statement. | ||
| // Choosing `FhirVersionEnum.R5` as the version to return here was an arbitrary choice. If we ever add support | ||
| // for R5, this test will need to be updated. | ||
| class MockFhirVersion extends org.hl7.fhir.r4.hapi.ctx.FhirR4{ | ||
| public FhirVersionEnum getVersion() { | ||
| return FhirVersionEnum.R5; | ||
| } | ||
| } | ||
| class MockFhirContext extends FhirContext { | ||
| @Override | ||
| public IFhirVersion getVersion() { | ||
| return new MockFhirVersion(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Let me know if you can think of a better way to do this
coilysiren
commented
Jun 10, 2024
Comment on lines
+34
to
+48
| @Test | ||
| void testGetStartDate() { | ||
| assertNull(EobUtils.getStartDate(eob1)); | ||
| assertNotNull(EobUtils.getStartDate(eob2)); | ||
| assertNull(EobUtils.getStartDate(eob3)); | ||
| assertNull(EobUtils.getStartDate((ExplanationOfBenefit) null)); | ||
| } | ||
|
|
||
| @Test | ||
| void testGetEndDate() { | ||
| assertNull(EobUtils.getEndDate(eob1)); | ||
| assertNotNull(EobUtils.getEndDate(eob2)); | ||
| assertNull(EobUtils.getEndDate(eob3)); | ||
| assertNull(EobUtils.getEndDate((ExplanationOfBenefit) null)); | ||
| } |
There was a problem hiding this comment.
Lazily choosing not to assert on the actual dates here
smirnovaae
approved these changes
Jun 10, 2024
Sadibhatla
approved these changes
Jun 10, 2024
| ExplanationOfBenefit eobSNF = (ExplanationOfBenefit) eobS; | ||
| List<org.hl7.fhir.dstu3.model.Identifier> ids = eobSNF.getIdentifier(); | ||
| assertNotNull(ids); | ||
| assertEquals(ids.size(), 2); |
| } | ||
|
|
||
| // DSTU3 | ||
| InputStream inputStream = classLoader.getResourceAsStream("eobdata/EOB-for-Carrier-Claims.json"); |
There was a problem hiding this comment.
add the file paths to constants? but I do understand if you dont want to since they are just being used few times in here
There was a problem hiding this comment.
I'd rather keep it as is, if that's okay!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6149
🛠 Changes
EobUtilsto handle a NPEEobUtilsandEOBLoadUtilities, both of which should be at 100% test coverage nowℹ️ Context for reviewers
SonarQube isn't updating the code coverage stats for my PR, so I won't know how much I've increased code coverage until after the merge (I think)
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.