Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AB2D-6147] increase ab2d-events-client coverage #398

Merged
merged 10 commits into from
Jun 25, 2024
Merged

[AB2D-6147] increase ab2d-events-client coverage #398

merged 10 commits into from
Jun 25, 2024

Conversation

coilysiren
Copy link
Contributor

@coilysiren coilysiren commented Jun 24, 2024

🎫 Ticket

https://jira.cms.gov/browse/AB2D-6147

🛠 Changes

A very repetitious PR for ab2d-events-client. Most of the test classes use testContructor and testAsMessage patterns, as that's the most consistent way to get 100% test coverage on these classes. The one exception is SlackEventsTest, which I'm not convinced is a good idea.

ℹ️ Context

Working in increase code coverage above 90%

@coilysiren coilysiren marked this pull request as ready for review June 25, 2024 14:58
@coilysiren coilysiren requested a review from a team as a code owner June 25, 2024 14:58
@coilysiren coilysiren merged commit f00e580 into main Jun 25, 2024
3 checks passed
@coilysiren coilysiren deleted the AB2D-6147 branch June 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants