Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-674 fix: policy resource references and bucket naming #147

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

timothy-ellis-ky
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/PLT-674

🛠 Changes

APPLY at merge of original PLT-674 failed due to policy resource reference mistakes (key alias vs ARN) and problematic naming of an S3 bucket.
These changes attempt to resolve.

ℹ️ Context

see above

🧪 Validation

plan succeeds

@timothy-ellis-ky timothy-ellis-ky requested a review from a team as a code owner November 14, 2024 14:17
Copy link
Member

@gsf gsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes!

@timothy-ellis-ky timothy-ellis-ky merged commit ae8123d into main Nov 14, 2024
6 checks passed
@timothy-ellis-ky timothy-ellis-ky deleted the PLT-674-fix branch November 14, 2024 16:19
ildesenesence pushed a commit that referenced this pull request Nov 15, 2024
## 🎫 Ticket

https://jira.cms.gov/browse/PLT-674

## 🛠 Changes

APPLY at merge of original PLT-674 failed due to policy resource
reference mistakes (key alias vs ARN) and problematic naming of an S3
bucket.
These changes attempt to resolve.

## ℹ️ Context

see above

## 🧪 Validation

plan succeeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants