Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-7864: Add Sonarqube quality gate check to PRs #171

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

kyeah
Copy link
Contributor

@kyeah kyeah commented Mar 26, 2024

🎫 Ticket

https://jira.cms.gov/browse/BCDA-7864

🛠 Changes

Add Sonarqube quality gate to pull request check

ℹ️ Context for reviewers

We run Sonarqube quality gates as part of builds and deployments, but not as part of PRs, so sometimes we'll merge a change and break the build/deploy.

We also have some security checks that we manage manually at the moment using a scheduled task. We can automate this within the pipeline.

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

Copy link
Contributor

@laurenkrugen-navapbc laurenkrugen-navapbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this in here.

@kyeah kyeah merged commit b8917ef into master Mar 27, 2024
5 checks passed
@kyeah kyeah deleted the kev/sonar-gate branch March 27, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants