Tech debt - Maven lifecycle updates #2326
Open
+2,000
−412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignore to ignore all contents in project tmp/ directory, but to create an empty directory (with .keep placeholder) to support local, cicd, and op tmp work as necessary.
…ugin. Preserving commit history on files by minimizing changes during rename.
…ation-tests profile
…than reusing Surefire (generally used to unit test)
…support for verbose test reporting when desired
NavaCharlesHorowitz
force-pushed
the
ceh1/tech-debt-oct24-2
branch
from
1a9f846
to
2a32c47
Compare
…smoketest is cleaned, compiled, and packaged during dpc-test.sh anyways, and recent updates to CICD/github action runner seem to have introduced new problems with our process
NavaCharlesHorowitz
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
This is one component of my catchall tech debt/housekeeping ticket:
DPC-4298
🛠 Changes
Updates to project POMs to implement Failsafe for integration test rather than reusing Surefire (generally limited to unit test)
Renamed integration test files consistent with Failsafe defaults (preserving commit history on these files)
Added test display names
Added test reporter to clean up maven output during build/test (flags added to enable out/err as needed)
Knocked out shade warnings
Updated maven plugin versions
Added maven clean plugin with config because CICD filelocks are slow to release
ℹ️ Context
Maven lifecycle activities, specifically package and test, were too cluttered with warnings and exception logging, making it difficult to understand the state of the software, quality and purpose of tests, and the results of specific development actions.
Given that development work is typically very scoped, reducing 99% of the noise produced makes it easier to focus on evaluating specific changes made. Easier to understand and evaluate the software as a whole based on monitoring maven lifecycle.
🧪 Validation
Ran local dpc-test.sh to verify. Encountered sporadic issues with final mvn clean compile of dpc-smoketest which is redundant, so I've disabled it temporarily. I believe changes made to cicd environment for csrap may have affected environment behaviors