Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt - Update Dependencies #2329

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

NavaCharlesHorowitz
Copy link
Contributor

@NavaCharlesHorowitz NavaCharlesHorowitz commented Nov 19, 2024

🎫 Ticket

This is one component of my catchall tech debt/housekeeping ticket:

DPC-4298

🛠 Changes

-Updated POMs with newer dependency versions
-Removed older jersey/guice/dropwizard utilities
-Updated classes for jakarta support and new guice/hk2/jakarta DI
-Removed deprecated code and some warnings
-Improved test isolation
-Performance adjustments

ℹ️ Context

Project dependencies are 4 - 8 years old. Deprecated code, EOL projects, increasingly inactive development community and inability to support eventual transition to JDK 17 are concerns that need to be addressed while preserving the basic integrity of the software design.

🧪 Validation

Local unit, integration, system, and smoke testing combined with trace logging to verify successful and correct implementation of new dependencies.

ceh1 and others added 15 commits November 16, 2024 21:48
…ignore to ignore all contents in project tmp/ directory, but to create an empty directory (with .keep placeholder) to support local, cicd, and op tmp work as necessary.
…ugin. Preserving commit history on files by minimizing changes during rename.
…than reusing Surefire (generally used to unit test)
…support for verbose test reporting when desired
…smoketest is cleaned, compiled, and packaged during dpc-test.sh anyways, and recent updates to CICD/github action runner seem to have introduced new problems with our process
…dModel interface needed by Dropwizard.

This will allow for cleaner transition to jakarta-only dependencies
…nder DPC control and updated for jakarta/hk2 support
@NavaCharlesHorowitz NavaCharlesHorowitz changed the title Tech Debt - Update dependency versions Tech Debt - Update Dependencies Nov 22, 2024
ceh1 added 3 commits November 22, 2024 09:27
…Adapter and made changes consistent with security model for JWTs to not rely on claims prior to signature verification.

Updated exception->response mapping
Tests updates and improved test isolation
Added DAO method to fetch key using keyid without org id
Updated POMs for transitive dependencies
Swapped-in dropwizard-guiciest
hk2/jakarta/guice code/annotation adjustment
transition to jakarta from javax
Some performance/singleton adjustments
Test updates and some further test isolation
Exception->response mapping updates
@NavaCharlesHorowitz NavaCharlesHorowitz added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 22, 2024
@NavaCharlesHorowitz NavaCharlesHorowitz marked this pull request as ready for review November 22, 2024 21:06
@NavaCharlesHorowitz NavaCharlesHorowitz requested a review from a team November 24, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant