Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Matched The Modified File(sorted.js) from Project NodeBB"" #60

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

NickDevi
Copy link

Reverts #57

Important Note: This pull request reverts a previously reverted change, restoring the feature to its original state. The purpose is to ensure that the correct reviewers are assigned to each task we implemented. Due to a repository configuration issue, automatic merging occurred before the assigned reviewers had officially approved the code. Although the reviewers completed their reviews on time, GitHub merged the code prematurely.

This "undo revert" pull request restores the changes from the original pull request #29. Please refer to that pull request to view the commit messages, as they are not displayed here. The reviewers from that pull request #29 can be seen here.

@NickDevi NickDevi added duplicate This issue or pull request already exists enhancement New feature or request labels Sep 26, 2024
@NickDevi NickDevi added this to the Sprint 1 milestone Sep 26, 2024
@NickDevi NickDevi self-assigned this Sep 26, 2024
Copy link

@DachiCharkviani DachiCharkviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, ready for merging.

Copy link

@khiyami khiyami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, ready for merging!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11055851718

Details

  • 43 of 47 (91.49%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 82.693%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/topics/sorted.js 43 47 91.49%
Totals Coverage Status
Change from base Build 11055780506: 0.007%
Covered Lines: 22343
Relevant Lines: 25596

💛 - Coveralls

@NickDevi NickDevi merged commit a43b8ff into f24 Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants