Work Done #104
Open
Work Done #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
debarati-06
requested changes
Jun 5, 2022
debarati-06
added
pending changes
All the 3 Mistakes are corrected
|
Now ive Resolved all the issues
…On Sun, Jun 5, 2022 at 11:33 PM Debarati Bandopadhyay < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In utils/contributors.js
<#104 (comment)>
:
> @@ -59,6 +59,35 @@ const CONTRIBUTERS = [
`,
github: "https://github.com/debarati-06",
},
+
+ {
+ handle_name: 'Harshith1263',
+ name: "Harshith",
+ image: "/home/harshith/CSOC22-Week0-namecards/public/images/Harshith.jpeg",
Image path is incorrect. It should be /images/Harshith.jpeg instead of
what you have mentioned.
------------------------------
In utils/contributors.js
<#104 (comment)>
:
> @@ -59,6 +59,35 @@ const CONTRIBUTERS = [
`,
github: "https://github.com/debarati-06",
},
+
Remove this blank line as it can cause merge conflicts
------------------------------
In utils/contributors.js
<#104 (comment)>
:
> +
+
Remove these blank lines as well.
—
Reply to this email directly, view it on GitHub
<#104 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYJJFYZ3YSDF3E5X2UNPRPLVNTTWTANCNFSM5X4YSRRQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
debarati-06
approved these changes
Jun 7, 2022
debarati-06
added
passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the mentioned changes are being done