Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lalit card #90

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Lalit card #90

wants to merge 3 commits into from

Conversation

9389lalit
Copy link

Roll no-21095068
Name:-Lalit Singh
Branch:- Electronics
Github handle:-lalit9389

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
csoc-22-week0-namecards ✅ Ready (Inspect) Visit Preview May 30, 2022 at 5:34PM (UTC)
csoc-week0-namecards ✅ Ready (Inspect) Visit Preview May 30, 2022 at 5:34PM (UTC)

@9389lalit
Copy link
Author

Lalit singh from Electronics engineering

@9389lalit
Copy link
Author

Lalit singh from Electronics engineering

@debarati-06 debarati-06 self-requested a review June 5, 2022 17:35
@@ -31,7 +31,7 @@ const CONTRIBUTERS = [
<lord-icon src="https://cdn.lordicon.com/jpdtnwas.json" trigger="loop" colors="primary:#121331,secondary:#e88c30" style="width:25px;height:25px"></lord-icon>
</div>
`,
github: "https://github.com/ankur12-1610",
github: "https://github.com/lalit9389",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only have to add your card and not edit the sample ones.

{
handle_name: 'lalit9389',
name: "Lalit Singh",
image: "anime.jpg",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image file path is incorrect.

<lord-icon src="https://cdn.lordicon.com/jpdtnwas.json" trigger="loop" colors="primary:#121331,secondary:#e88c30" style="width:25px;height:25px"></lord-icon>
</div>
`,
github: "https://github.com/lalit9389",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your GitHub link is non-functional. Provide correct links or you may skip it.

@debarati-06 debarati-06 added the pending changes requested changes in the pull request label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending changes requested changes in the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants