Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATED] Landing Page #152

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

atulyadav745
Copy link

@atulyadav745 atulyadav745 commented Dec 22, 2022

Description

Fixes

Fixes #[124 ] by @[issue author]

Types of changes

  • Bug/Hot fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring Old Code ( non-breaking change replacing already existing code )
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guidelines in repository.
  • My pull request has a descriptive title and is attached to an existing issue.
  • I haven't repeated the code and it follows established code style of repository.
  • My branch is up-to-date with upstream branch.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for cops ready!

Name Link
🔨 Latest commit 2e04ffb
🔍 Latest deploy log https://app.netlify.com/sites/cops/deploys/63a83d627cc5d70008df229a
😎 Deploy Preview https://deploy-preview-152--cops.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atulyadav745 atulyadav745 changed the title New branch [UPDATED] Landing Page Dec 22, 2022
Copy link
Member

@IamEzio IamEzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@king-11 PTAL.
Also tagging @soustab10 to check if the hero section on mobile screens looks as expected.

@king-11
Copy link
Member

king-11 commented Dec 25, 2022

LGTM 🎊

@soustab10
Copy link
Member

@atulyadav745 In mobile view, move the lower blob to a position closer to the text. Rest LGTM 👍
image

@atulyadav745
Copy link
Author

@soustab10 Done with required changes

@soustab10
Copy link
Member

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants