feat(worker): added worker state. #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Related to #375 (Rewrite worker as broker consumer) |
GoldenBadger
requested changes
Mar 13, 2018
worker/src/state/file.rs
Outdated
|
|
||
| use super::*; | ||
|
|
||
| use cerberus_proto::datatypes::{Task, TaskKind, TaskStatus}; |
There was a problem hiding this comment.
Nit: this should be:
use cerberus_proto [...]
use super::*;
worker/src/state/file.rs
Outdated
| pub fn new(path: &PathBuf) -> Result<Self, StateError> { | ||
| Ok(FileStore { | ||
| path: path.clone(), | ||
| jobs_path: [&path, &PathBuf::from(JOBS_DIR)].iter().collect(), |
There was a problem hiding this comment.
Can't this use Path::join?
worker/src/state/mod.rs
Outdated
| pub enum StateErrorKind { | ||
| #[fail(display = "Failed to connect to state store server.")] | ||
| ConnectionFailed, | ||
| #[fail(display = "Failed precondition")] |
There was a problem hiding this comment.
This error message is too vague.
worker/src/state/mod.rs
Outdated
| TaskSerialisationFailed, | ||
| #[fail(display = "Failed to deserialise the task proto.")] | ||
| TaskDeserialisationFailed, | ||
| #[fail(display = "Failed operation.")] |
GoldenBadger
requested changes
Mar 13, 2018
worker/src/state/file.rs
Outdated
| @@ -23,53 +22,50 @@ impl FileStore { | |||
| pub fn new(path: &PathBuf) -> Result<Self, StateError> { | |||
| Ok(FileStore { | |||
| path: path.clone(), | |||
| jobs_path: [&path, &PathBuf::from(JOBS_DIR)].iter().collect(), | |||
| jobs_path: path.clone().join(JOBS_DIR), | |||
There was a problem hiding this comment.
There shouldn't be a need for clone before join as join just takes a reference to self and returns a new object.
VoyTechnology
force-pushed
the
feature/worker-state
branch
from
480bbd0
to
7a69565
Compare
GoldenBadger
approved these changes
Mar 13, 2018
|
Sorry, I thought it was only squash that was bad. |
VoyTechnology
force-pushed
the
feature/worker-state
branch
2 times, most recently
from
641ef84
to
a4cb87a
Compare
This currently contains one method which manages updating the task and removing the pending tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently contains one method which manages updating the task and
removing the pending tasks.
Related to #393