feat: expand box types and match order #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnchildren
commented
Sep 8, 2023
johnchildren
commented
- Expand box types to support more (but not all) of the current possible pytket box types.
- Re-order the OpType variants to match those of the boxes.
- Expand box types to support more (but not all) of the current possible pytket box types. - Re-order the OpType variants to match those of the boxes.
johnchildren
commented
Sep 8, 2023
johnchildren
commented
Sep 8, 2023
aborgna-q
approved these changes
Sep 11, 2023
| /// NYI | ||
| CliffBox, | ||
|
|
||
| /// See \ref CustomGate | ||
| CustomGate, |
There was a problem hiding this comment.
Is this not needed anymore?
There was a problem hiding this comment.
As far as I can tell CustomGate is the same as Composite I believe.
There was a problem hiding this comment.
50788ab Fixed here
The left member of the tuple should be a Register.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
## 🤖 New release * `tket-json-rs`: 0.1.1 -> 0.2.0 (⚠️ API breaking changes) ###⚠️ `tket-json-rs` breaking changes ``` --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.24.0/src/lints/enum_struct_variant_field_added.ron Failed in: field cx_config of variant OpBox::PauliExpBox in /tmp/.tmpycvRG8/tket-json-rs/src/circuit_json.rs:109 field control_state of variant OpBox::QControlBox in /tmp/.tmpycvRG8/tket-json-rs/src/circuit_json.rs:166 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.2.0 (2023-10-16) ### Features - Expand box types and match order ([#15](#15)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.